Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when body is declared before if blocks #61

Open
mholt opened this issue Aug 29, 2024 · 0 comments · May be fixed by #64
Open

False positive when body is declared before if blocks #61

mholt opened this issue Aug 29, 2024 · 0 comments · May be fixed by #64

Comments

@mholt
Copy link

mholt commented Aug 29, 2024

In this code, the body gets closed, but it is reported:

var resp *http.Response
if a {
	resp, err = httpClient.Do(req) // <-- false positive on this line
	if err != nil {
		return err
	}
} else {
	// resp = something else
}
defer resp.Body.Close()

The idea is that I can use just a single defer line to close the response body, no matter where it comes from.

@ma91n ma91n linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant