Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cargo make + docker for e2e tests #18

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

matthew-hagemann
Copy link
Collaborator

@matthew-hagemann matthew-hagemann commented Sep 1, 2023

Changes:

  • Docker & Docker compose to setup and bootstrap test env
  • cargo make to manage test lifecycles

To run tests:

  • Update local .env, see updated example.env for new variables Docker will need.
  • install cargo make: cargo install --force cargo-make
  • cargo make full-test

To clean up:

  • cargo make full-clean

The rust solution for managing the lifecycle of the server and the tests was becoming way more complicated than just managing through bash, but let me know what you think.

What do you think about how I have structured the docker-compose and the Dockerfiles it calls?
My thinking was to keep the logic for bootstrapping out of the compose file.

The output is quite noisy at the moment with all of the info traces we have. We could look to either not log what happens in the server for the tests, or reduce the number of info traces.

@matthew-hagemann matthew-hagemann marked this pull request as ready for review September 1, 2023 10:59
@matthew-hagemann matthew-hagemann merged commit 4133b3c into tim-hm:dev Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant