Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for PHP < 7.2, fix PHP 8.4 compatibility #247

Merged
merged 1 commit into from
Jul 6, 2024
Merged

drop support for PHP < 7.2, fix PHP 8.4 compatibility #247

merged 1 commit into from
Jul 6, 2024

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented May 2, 2024 •
edited
Loading

@xabbuh xabbuh mentioned this pull request May 2, 2024
Closed
@xabbuh xabbuh changed the title drop support for PHP < 7.4, fix PHP 8.4 compatibility drop support for PHP < 7.2, fix PHP 8.4 compatibility Jul 6, 2024
@stof
Copy link
Collaborator

stof commented Jul 6, 2024

To fix the --prefer-lowest job, you can change the phpunit requirement to keep only PHPUnit 8+ (as PHPUnit 8 supports PHP 7.2)

@stof stof merged commit 97b4134 into tijsverkoyen:master Jul 6, 2024
12 checks passed
@xabbuh xabbuh deleted the twig-4056 branch July 6, 2024 13:11
@jmsche
Copy link

jmsche commented Nov 29, 2024

Hi @stof, could you please create a new release? PHP 8.4 was released last week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @stof @jmsche