Removing create service step for Felix metrics #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing create service step for Felix metrics as this step is automated through code.
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
rene-dekker
reviewed
Nov 28, 2024
| @@ -272,24 +272,6 @@ For all Prometheus Felix configuration values, see [Felix Prometheus](../../../r | |||
|
|
|||
| **Create a service to expose Felix metrics** | |||
|
|
|||
| ```bash | |||
There was a problem hiding this comment.
Technically, for cloud this should be merged once they integrate v3.22.0-1.0, is that right? Because that is the first operator release that will have the changes for cloud users.
@ctauchen What is the best way to make sure we merge the diffs in this file later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing create service step for Felix metrics as this step is automated through code.
Product Version(s):
Issue:
https://tigera.atlassian.net/browse/EV-5305
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: