You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This dawned on me while preparing #6022, but the naming scheme for several (internal) functions is at times somewhat confusing.
Especially now that we're using the imported check_*() functions from {rlang}, it feels out of place to have ggplot2-native check_*() functions do something else than throwing errors/warnings. For example check_linewidth() returns data.
The inverse is also true, we have functions that are used solely for throwing errors/warnings, but don't have the check_*() prefix. An example of this is validate_element().
I understand these names precede the rlang checks, but it probably won't hurt to make the names more consistent.
The text was updated successfully, but these errors were encountered:
This dawned on me while preparing #6022, but the naming scheme for several (internal) functions is at times somewhat confusing.
Especially now that we're using the imported
check_*()
functions from {rlang}, it feels out of place to have ggplot2-nativecheck_*()
functions do something else than throwing errors/warnings. For examplecheck_linewidth()
returns data.The inverse is also true, we have functions that are used solely for throwing errors/warnings, but don't have the
check_*()
prefix. An example of this isvalidate_element()
.I understand these names precede the rlang checks, but it probably won't hurt to make the names more consistent.
The text was updated successfully, but these errors were encountered: