Merge pull request #476 from tidymodels/missing-cast

Make all survival metrics work with case weights
tidymodels · Jan 12, 2024 · 81e2cc6 · 81e2cc6
2 parents 53e1f1c + c7887c9
commit 81e2cc6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: yardstick
 Title: Tidy Characterizations of Model Performance
-Version: 1.2.0.9002
+Version: 1.2.0.9003
 Authors@R: c(
     person("Max", "Kuhn", , "[email protected]", role = "aut"),
     person("Davis", "Vaughan", , "[email protected]", role = "aut"),

diff --git a/R/surv-brier_survival.R b/R/surv-brier_survival.R
@@ -138,6 +138,7 @@ brier_survival_impl <- function(truth,
   surv_status <- .extract_surv_status(truth)
 
   if (!is.null(case_weights)) {
+    case_weights <- vec_cast(case_weights, to = double())
     norm_const <- sum(case_weights)
   } else {
     case_weights <- rep(1, length(estimate))

diff --git a/R/surv-concordance_survival.R b/R/surv-concordance_survival.R
@@ -104,6 +104,8 @@ concordance_survival_vec <- function(truth,
 concordance_survival_impl <- function(truth, estimate, case_weights) {
   if (is.null(case_weights)) {
     case_weights <- rep(1, length(estimate))
+  } else {
+    case_weights <- vec_cast(case_weights, to = double())
   }
 
   survival::concordance(truth ~ estimate, weights = case_weights)$concordance