Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide/document stance on partially trained workflows #231

Open
simonpcouch opened this issue May 31, 2024 · 1 comment
Open

decide/document stance on partially trained workflows #231

simonpcouch opened this issue May 31, 2024 · 1 comment

Comments

@simonpcouch
Copy link
Contributor

re:

# note that the preprocessor and model fit don't need to be "untrained"
# with new_stage_* since they are unaffected by the post-processor.
new_workflow(
pre = x$pre,
fit = x$fit,
post = new_stage_post(actions = actions),
trained = FALSE
)

In the PR thread:

ec0effa surfaces an important point; removing/updating a postprocessor from an otherwise trained workflow need not remove the preprocessor and model fits, as they won't be affected by the removal of the postprocessor. This introduces the possibility of a "partially trained" workflow, where a workflow with trained preprocessor and model but untrained postprocessor should be able to fit without issue.

@simonpcouch
Copy link
Contributor Author

This was already the case with preprocessors and models before. We'll continue only supporting partially-trained workflows via the @keywords internal .fit_*() functions and document as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant