From cc622251cc2707533189f23978491bf3a2d297eb Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Thu, 14 Nov 2024 12:49:22 -0800 Subject: [PATCH 1/2] update snapshot --- tests/testthat/_snaps/pre-action-case-weights.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/_snaps/pre-action-case-weights.md b/tests/testthat/_snaps/pre-action-case-weights.md index 96edb318..bc063459 100644 --- a/tests/testthat/_snaps/pre-action-case-weights.md +++ b/tests/testthat/_snaps/pre-action-case-weights.md @@ -4,7 +4,7 @@ predict(wf, df) Condition Error in `validate_column_names()`: - ! The following required columns are missing: 'w'. + ! The required column "w" is missing. # case weights + recipe requires extra roles at predict time by default @@ -12,7 +12,7 @@ predict(wf, df) Condition Error in `validate_column_names()`: - ! The following required columns are missing: 'w'. + ! The required column "w" is missing. # case weights + recipe doesn't allow the recipe to drop the case weights column From 805a78a588bc12133e74c72e6f4d8065459507ce Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Thu, 14 Nov 2024 12:49:34 -0800 Subject: [PATCH 2/2] adhere to stricter recipes checking --- tests/testthat/test-generics.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-generics.R b/tests/testthat/test-generics.R index ff5c73ae..25caa856 100644 --- a/tests/testthat/test-generics.R +++ b/tests/testthat/test-generics.R @@ -17,7 +17,7 @@ test_that("can compute required packages of a workflow - recipes", { mod <- parsnip::linear_reg() mod <- parsnip::set_engine(mod, "lm") - step <- recipes::step("workflows_test") + step <- recipes::step("workflows_test", trained = FALSE, id = "", skip = FALSE, role = NA) rec <- recipes::recipe(mpg ~ cyl, mtcars) rec <- recipes::add_step(rec, step)