Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should adjust_equivocal_zone(threshold) know about adjust_probability_threshold()? #39

Closed
simonpcouch opened this issue Sep 17, 2024 · 1 comment
Closed

should adjust_equivocal_zone(threshold) know about adjust_probability_threshold()? #39

simonpcouch opened this issue Sep 17, 2024 · 1 comment

Comments

@simonpcouch
Copy link
Contributor

In:

tailor/R/adjust-equivocal-zone.R

Line 50 in 6704eb6

adjust_equivocal_zone <- function(x, value = 0.1, threshold = 1 / 2) {

Feels somewhat strange to me that a user could use adjust_probability_threshold() and then adjust_equivocal_zone() with a different threshold?
@simonpcouch
Copy link
Contributor Author

Oh, duplicate of #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonpcouch