Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check_args() to remaining model types #1094

Open
EmilHvitfeldt opened this issue Apr 2, 2024 · 0 comments
Open

Add check_args() to remaining model types #1094

EmilHvitfeldt opened this issue Apr 2, 2024 · 0 comments
Labels
feature a feature request or enhancement upkeep maintenance, infrastructure, and similar

Comments

@EmilHvitfeldt
Copy link
Member

EmilHvitfeldt commented Apr 2, 2024 •
edited
Loading

The following models doesn't have check_args() methods and could properly benefit (and in personal opinion it would be nice to have complete coverage)

  • bag_mars
  • bag_mlp
  • bart
  • discrim_quad
  • gen_additive_mod
  • naive_Bayes
  • proportional_hazards
  • rule_fit
  • null_model

isn't a blocker for #1093 because there are no errors to check
@EmilHvitfeldt EmilHvitfeldt added feature a feature request or enhancement upkeep maintenance, infrastructure, and similar labels Apr 2, 2024
@EmilHvitfeldt EmilHvitfeldt mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EmilHvitfeldt