Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify vignettes and articles to match tidy formatting #540

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

Joscelinrocha
Copy link
Contributor

Added missing commas and formatting issues throughout the vignettes. Backticks for package names were removed, and missing parentheses for functions were added.

Added missing commas and formatting issues throughout the vignettes. Backticks for package names were removed, and missing parentheses for functions were added.
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks so much. I suggested a couple further style edits but this looks super close to ready to merge.

Also, you're welcome to credit yourself for these changes in a NEWS entry!

vignettes/chi_squared.Rmd Outdated Show resolved Hide resolved
vignettes/chi_squared.Rmd Outdated Show resolved Hide resolved
vignettes/observed_stat_examples.Rmd Outdated Show resolved Hide resolved
vignettes/observed_stat_examples.Rmd Outdated Show resolved Hide resolved
@andrewpbray
Copy link
Collaborator

This is great - thanks @Joscelinrocha !

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @Joscelinrocha—great to have you at TDD!

README.Rmd Outdated Show resolved Hide resolved
@simonpcouch simonpcouch merged commit 10c9901 into tidymodels:main Aug 16, 2024
8 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants