fix bug in prop.test() wrapper
#502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Jul 24, 2023
| @@ -258,11 +258,11 @@ test_that("conf_int argument works", { | |||
| }) | |||
|
|
|||
| # generate some data to test the prop.test wrapper | |||
| df <- data.frame(resp = c(rep("c", 450), | |||
| df <- data.frame(exp = rep(c("a", "b"), each = 500), | |||
There was a problem hiding this comment.
Instead of adjusting each table() call further down to tabulate the first variable as the "column," I just adjusted the order in which the variables in this dataset were defined.
|
|
||
| # reorder according to the order and success arguments | ||
| sum_table <- sum_table[lvls, order] | ||
| select(explanatory_name(x), response_name(x)) %>% |
There was a problem hiding this comment.
It's not obvious to me how we could formally test which selection order is "right," though I'm quite confident it's correct now. :)
mine-cetinkaya-rundel
approved these changes
Aug 22, 2023
Co-authored-by: Mine Cetinkaya-Rundel <[email protected]>
|
Seeing the same failures on |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496. See that issue for discussion. :)