From b97f6f00eb2e9f12a6a9ee09f0f1e2836da69a67 Mon Sep 17 00:00:00 2001 From: Hannah Frick Date: Mon, 21 Oct 2024 15:47:22 +0100 Subject: [PATCH 1/3] add check without Suggests --- .github/workflows/R-CMD-check-hard.yaml | 60 +++++++++++++++++++++++++ README.Rmd | 1 + README.md | 1 + 3 files changed, 62 insertions(+) create mode 100644 .github/workflows/R-CMD-check-hard.yaml diff --git a/.github/workflows/R-CMD-check-hard.yaml b/.github/workflows/R-CMD-check-hard.yaml new file mode 100644 index 00000000..27340b00 --- /dev/null +++ b/.github/workflows/R-CMD-check-hard.yaml @@ -0,0 +1,60 @@ +# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples +# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help +# +# NOTE: This workflow only directly installs "hard" dependencies, i.e. Depends, +# Imports, and LinkingTo dependencies. Notably, Suggests dependencies are never +# installed, with the exception of testthat, knitr, and rmarkdown. The cache is +# never used to avoid accidentally restoring a cache containing a suggested +# dependency. +on: + push: + branches: [main, master] + pull_request: + branches: [main, master] + +name: check-no-suggests.yaml + +permissions: read-all + +jobs: + check-no-suggests: + runs-on: ${{ matrix.config.os }} + + name: ${{ matrix.config.os }} (${{ matrix.config.r }}) + + strategy: + fail-fast: false + matrix: + config: + - {os: ubuntu-latest, r: 'release'} + + env: + GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} + R_KEEP_PKG_SOURCE: yes + + steps: + - uses: actions/checkout@v4 + + - uses: r-lib/actions/setup-pandoc@v2 + + - uses: r-lib/actions/setup-r@v2 + with: + r-version: ${{ matrix.config.r }} + http-user-agent: ${{ matrix.config.http-user-agent }} + use-public-rspm: true + + - uses: r-lib/actions/setup-r-dependencies@v2 + with: + dependencies: '"hard"' + cache: false + extra-packages: | + any::rcmdcheck + any::testthat + any::knitr + any::rmarkdown + needs: check + + - uses: r-lib/actions/check-r-package@v2 + with: + upload-snapshots: true + build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")' diff --git a/README.Rmd b/README.Rmd index 183c7080..370fe339 100644 --- a/README.Rmd +++ b/README.Rmd @@ -23,6 +23,7 @@ knitr::opts_chunk$set( [![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/dials)](https://CRAN.R-project.org/package=dials) [![Downloads](http://cranlogs.r-pkg.org/badges/dials)](https://CRAN.R-project.org/package=dials) [![lifecycle](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html) +[![R-CMD-check-hard](https://github.com/tidymodels/dials/actions/workflows/R-CMD-check-hard.yaml/badge.svg)](https://github.com/tidymodels/dials/actions/workflows/R-CMD-check-hard.yaml) ## Overview diff --git a/README.md b/README.md index 17deb733..2505187f 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,7 @@ coverage](https://codecov.io/gh/tidymodels/dials/branch/main/graph/badge.svg)](h [![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/dials)](https://CRAN.R-project.org/package=dials) [![Downloads](http://cranlogs.r-pkg.org/badges/dials)](https://CRAN.R-project.org/package=dials) [![lifecycle](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html) +[![R-CMD-check-hard](https://github.com/tidymodels/dials/actions/workflows/R-CMD-check-hard.yaml/badge.svg)](https://github.com/tidymodels/dials/actions/workflows/R-CMD-check-hard.yaml) ## Overview From 298ad74780c11f86bbb953d40a3bb3df3559a3c1 Mon Sep 17 00:00:00 2001 From: Max Kuhn Date: Tue, 22 Oct 2024 13:05:49 -0400 Subject: [PATCH 2/3] Update .github/workflows/R-CMD-check-hard.yaml --- .github/workflows/R-CMD-check-hard.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/R-CMD-check-hard.yaml b/.github/workflows/R-CMD-check-hard.yaml index 27340b00..c06bf8f9 100644 --- a/.github/workflows/R-CMD-check-hard.yaml +++ b/.github/workflows/R-CMD-check-hard.yaml @@ -12,7 +12,7 @@ on: pull_request: branches: [main, master] -name: check-no-suggests.yaml +name: R-CMD-check-no-suggests.yaml permissions: read-all From ea482e2f43476d3e56bc417c00beb3f5871a80a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=98topepo=E2=80=99?= Date: Tue, 22 Oct 2024 13:36:58 -0400 Subject: [PATCH 3/3] work arounds when no kernlab --- tests/testthat/test-finalize.R | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/testthat/test-finalize.R b/tests/testthat/test-finalize.R index 2464eb43..cf477922 100644 --- a/tests/testthat/test-finalize.R +++ b/tests/testthat/test-finalize.R @@ -1,6 +1,4 @@ -suppressMessages(library(kernlab)) - test_that("estimate columns", { expect_snapshot(error = TRUE, get_p(1:10)) expect_snapshot(error = TRUE, get_p(1:10, 1:10)) @@ -48,6 +46,9 @@ test_that("estimate rows", { test_that("estimate sigma", { + skip_if_not_installed("kernlab") + suppressMessages(library(kernlab)) + expect_snapshot(error = TRUE, get_rbf_range(rbf_sigma(), iris)) run_1 <- range_get(get_rbf_range(rbf_sigma(), mtcars, seed = 5624)) @@ -58,6 +59,9 @@ test_that("estimate sigma", { test_that("force", { + skip_if_not_installed("kernlab") + suppressMessages(library(kernlab)) + rbf_sigma_final <- finalize(rbf_sigma(), mtcars) rbf_sigma_same <- finalize(rbf_sigma(), mtcars, force = FALSE)