Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace rlang::warn() with cli::cli_warn() #350

Merged
merged 4 commits into from
Sep 20, 2024
Merged

replace rlang::warn() with cli::cli_warn() #350

merged 4 commits into from
Sep 20, 2024

Conversation

EmilHvitfeldt
Copy link
Member

ref: #311

Nothing super special here

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One small ask in the comments ℹ️

R/grids.R Outdated Show resolved Hide resolved
@hfrick
Copy link
Member

hfrick commented Sep 20, 2024

Ah, I meant for all of them, to keep them in sync! Done it now, merge time! ✅

@hfrick hfrick merged commit 7beb7ea into main Sep 20, 2024
11 checks passed
@hfrick hfrick deleted the cli-warn-replace branch September 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants