Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make S3 methods for grid functions that dispatch from model/recipe/workflow #335

Closed
topepo opened this issue Jul 13, 2024 · 1 comment
Closed
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@topepo
Copy link
Member

topepo commented Jul 13, 2024

To eliminate a step of extracting the parameter set and for future-proofing for mixed grids (where we need to know about submodel parameters).

@topepo topepo added tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day feature a feature request or enhancement labels Jul 13, 2024
@hfrick
Copy link
Member

hfrick commented Jul 17, 2024

So grid_random.recipe() or grid_space_filling.workflow()? Since we generally try to stick S3 methods for a class into the same package as the class itself, should we open issues for this on recipes/parsnip/workflows?

@topepo topepo closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

2 participants