Test is flaky

[MichaelChirico]

This test can fail randomly:

dials/tests/testthat/test-aaa_values.R

Lines 174 to 177 in 55763e0

	expect_equal(
	sort(unique(value_sample(value_seq, 40))),
	value_seq$values
	)

library(dials)
library(testthat)

value_seq <- new_quant_param(
  type = "double",
  range = c(0.0, 1.0),
  inclusive = c(TRUE, TRUE),
  trans = NULL,
  values = (0:5) / 5,
  label = c(param = "param")
)
test_fails <- function(n = 40L) {
  value_sample(value_seq, n) |>
  unique() |>
  sort() |>
  expect_equal(value_seq$values) |>
  tryCatch(error = identity) |>
  inherits("error")
}
table(replicate(1000, test_fails()))
# FALSE  TRUE 
#   996     4 

[MichaelChirico]

If I up the sample size to 50L it is less than 0.1% failure:

table(replicate(5000, test_fails(50)))
# FALSE  TRUE 
#  4999     1

[hfrick]

Thanks for the issue and PR @MichaelChirico ! You may have been looking at an outdated version of this test though, that's not what it looks like on main now. I've changed it a while back in #297. I appreciate the contribution but I'm okay with the current version and am going to close the issue and PR.

[MichaelChirico]

not sure how I missed the updated test! I agree your implementation is much preferable since it has probability 1 of succeeding. thanks!

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.