Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: visiting sound without a pack from the sound page of a sound with a pack causes old pack to persist #329

Open
hamirmahal opened this issue Sep 21, 2021 · 0 comments
Assignees
Labels
bug Something isn't working p2 Medium priority

Comments

@hamirmahal
Copy link
Member

Bug

Note the address bar: this is on the production version of the application, not localhost.

Visiting a sound without a pack, from the sound page of a sound that does have a pack, causes the pack from the previous sound to persist, making it seem as if the current sound has a pack, when it really doesn't.

Screen.Recording.2021-09-21.at.4.53.51.PM.mov

Workaround

Visit the packless sound through the address bar.

Notice how the sound correctly doesn't display a pack soundlist, because it doesn't have one.

Screen.Recording.2021-09-21.at.4.56.15.PM.mov

@amilajack What do you think of adding a test case to our suite that reproduces this bug?

I would like to contribute the fix for this!

@hamirmahal hamirmahal self-assigned this Sep 21, 2021
@hamirmahal hamirmahal added bug Something isn't working infra internal, infrastructure related work p2 Medium priority testing and removed infra internal, infrastructure related work testing labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2 Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant