-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample Quality, Normalization and Loudness #8
Comments
This is good - some more detail on how this should look/waveforms and examples of some common good examples, or a reference set would be great in a README |
Thanks @jkbd! I know very little about sample mastering really and this all sounds great. I think we should be careful not to discourage contributions, so tackling this in two parts in the README could be a good idea. One bit that says more or less what it does now, and another 'advanced' bit with all this additional advice. Personally I'm not super worried about this stuff, I guess loudness is just another property of a sample that I play with when improvising. Our aim isn't necessarily to compete with commercial software in making conventional sounding recordings for radio play. So the priority is to have a nice diverse set of sample banks that people can contribute to as easily as possible. On the other hand this is all good advice, which we should try to follow when choosing sample packs for the 'default' superdirt samples etc. This sample mastering could happen at a later stage though. |
I've updated the readme a bit - PRs very welcome! |
Later I might provide a Python script that complains if a given
|
Good points! As far as SuperDirt is concerned (I see that this may not matter)
|
Some analysis of Dirt-Samples: You can peek at the Python code. DC-offset can be improved a lot! (Edit: |
Interesting! Dirt-Samples is mostly just the contents of my hard drive from ten years ago.. |
I just learned, 8-bit samples can possibly be unsigned. That file is also from Dirt-Samples:
With unsigned encoding the mean of a sinewave is not zero! The scipt above counted this file and some more as "with DC-offset". |
Heh, those samples are probably ripped from a MAME rom. I think I made the 'mp3' ones by reading mp3 files as raw data. |
Thanks for the effort so far!
In ddbc883 the README states:
I did some experiments with Dirt-Samples in the past and found that normalization is complicated. What comes to my mind is:
So my suggestions to rephrase this, are:
Probably this could form a new section in the README on "Sample Quality". Also with:
What do you think?
The text was updated successfully, but these errors were encountered: