[Player] Unified caching (2/X): Unified CacheStorage setup
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asendra
force-pushed
the
alberto/setup-unified-caching
branch
from
99798cd
to
c236d9e
Compare
asendra
force-pushed
the
alberto/remove-legacy-player-impl
branch
from
c14cd75
to
a81e746
Compare
asendra
force-pushed
the
alberto/setup-unified-caching
branch
from
c236d9e
to
4f506a7
Compare
asendra
changed the title
CacheStorage setup
ceciliasaraiva
approved these changes
Nov 29, 2024
| @@ -8,7 +8,8 @@ import XCTest | |||
| final class PlayerTests: XCTestCase { | |||
| private var player: Player! | |||
| private var playerEventSender: PlayerEventSenderMock! | |||
| private var dbQueue: DatabaseQueue! | |||
| private var offlineDbQueue: DatabaseQueue! | |||
| private var cachedDQueue: DatabaseQueue! | |||
There was a problem hiding this comment.
[suggestion] small typo I guess to make it consistent with the above
Suggested change
| private var cachedDQueue: DatabaseQueue! | |
| private var cachedDbQueue: DatabaseQueue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With the legacy Player implementation out of the picture, we can start migrating all
GenericMediaPlayerimplementations to use the new unified caching layer.This will allow us to enforce a LIFO with maximum storage size quotas between all of them, and the possibility to inform of the storage usage and the ability to clear the cache as requested.
Description
This PR only takes care of initializing the
CacheStorage, and passing it to the relevant layers in preparation.