Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running latest qgit on Mac OS X 10.6.8 has memory leaks #89

Open
NucleaPeon opened this issue Mar 5, 2020 · 6 comments
Open

Running latest qgit on Mac OS X 10.6.8 has memory leaks #89

NucleaPeon opened this issue Mar 5, 2020 · 6 comments

Comments

@NucleaPeon
Copy link

When running qgit on the command line on snow leopard, I get these messages:

qgit-mem-leak

Applying the CocoaInitializer fix results in no error messages:

prevent-mem-leaks

You can find the fixes in my forked repo:
https://github.com/NucleaPeon/qgit

I built qgit using Qt 5.3.2.

Thanks for building/maintaining this piece of software.

@tibirna
Copy link
Owner

tibirna commented Mar 9, 2020

Hello Dan

Thank you very much for this contribution. It is very much appreciated, in particular given that I don't have access to a MacOS machine for development so your help is very useful.

Please consider making a pull request so that I can merge your changes in the main qgit repo.

Thanks
Cristian

@NucleaPeon
Copy link
Author

NucleaPeon commented Mar 10, 2020

I made a pull request, but this is the first time doing so on github. Let me know if I need to take additional steps. I squashed it into one commit and put it in a branch.

https://github.com/NucleaPeon/qgit/tree/macosx-10.6.8-memleak-fix

@NucleaPeon
Copy link
Author

I'd hold off merging it just yet, there's an issue with some of the main menu being duplicated.

@NucleaPeon
Copy link
Author

OK ready for merge

@tibirna
Copy link
Owner

tibirna commented Mar 15, 2020

Your pull request didn't work (I can't see it in my list). From what I can tell, you made against your repository.

When generating the pull request, choose the base repo to be tibirna/qgit.

@NucleaPeon
Copy link
Author

Sorry, I'm unfamiliar with github's workflow. I've forked directly from you and patched in the changes into their own branch.
#91

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants