Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] App icon is broken on Sonoma / arm64 #141

Open
barracuda156 opened this issue Jan 2, 2024 · 6 comments
Open

[macOS] App icon is broken on Sonoma / arm64 #141

barracuda156 opened this issue Jan 2, 2024 · 6 comments

Comments

@barracuda156
Copy link

This is not how it is supposed to look, I assume?

qgit

Built with Qt5.

@tibirna
Copy link
Owner

tibirna commented Jan 3, 2024

Thanks for your report.

More info will be needed. As we can verify, the original files in the source repo are OK:
https://github.com/tibirna/qgit/blob/master/src/resources/qgit.png
https://github.com/tibirna/qgit/blob/master/src/resources/qgit.svg

@barracuda156
Copy link
Author

@tibirna Have you got an arm64 Mac hardware? This should be reproducible, I believe, at least on Sonoma, by just installing qgit from Macports.

@filiperinaldi
Copy link
Contributor

Hi @barracuda156 , I had a quick look since I was the last one to update the icon used for the MacOS.
It seems the problem is related to the available icon sizes in the icon set file (qgit.icns).

It seems at the time I only added one size (64x64) which was made from a SVG file I created to increase the resolution as the original icon was very small and blurry on the newer high resolution screens.

I have now created an icon set with many more sizes which MacOS Sonoma is happy with. They must have changed something to use a specific image size.

Have a look into the PR #142

@filiperinaldi
Copy link
Contributor

filiperinaldi commented Jan 4, 2024

Thanks for your report.

More info will be needed. As we can verify, the original files in the source repo are OK: https://github.com/tibirna/qgit/blob/master/src/resources/qgit.png https://github.com/tibirna/qgit/blob/master/src/resources/qgit.svg

@tibirna , the MacOS installation uses the https://github.com/tibirna/qgit/blob/master/src/resources/qgit.icns file which is a set of icons at different resolutions.

@barracuda156
Copy link
Author

@filiperinaldi Great, I will try it. Thank you!

@tibirna
Copy link
Owner

tibirna commented Jan 5, 2024

Thank you, @filiperinaldi, for looking into this. I will merge the branch as is, even without confirmation of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants