Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document elimination of commit message metadata #44

Open
Tracked by #35
makubacki opened this issue Jun 15, 2023 · 1 comment
Open
Tracked by #35

Document elimination of commit message metadata #44

makubacki opened this issue Jun 15, 2023 · 1 comment

Comments

@makubacki
Copy link
Member

makubacki commented Jun 15, 2023

The previous GitHub contribution process required additional metadata in commit message no longer needed.

The following is no longer required:

  • Cc lines
    • Stakeholders are assigned to PRs they need to review
  • Review tags: Reviewed-by, Acked-by, and Tested-by
    • The email history of the PR will preserve who approved the PR.

This removes the need to update the PR after the code review portion of the PR is finished.

Note: Signed-off-by is still required on all commit messages to indicate the developer agrees to the Developer Certificate of Origin (DCO).

@makubacki
Copy link
Member Author

makubacki commented Oct 13, 2023

Note that the Signed-off-by person and author may be different. The Signed-off-by developer should be the one that opens the PR.

A GitHub workflow should be in place to ensure that the Signed-off-by information is present and correctly formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant