Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping the dollar sign in build_rules.txt not possible (Bugzilla Bug 297) #9570

Open
tianocore-issues opened this issue Dec 15, 2016 · 3 comments
Labels
package:basetools priority:high Significant impact. Should be fixed as soon as possible. type:bug Something isn't working

Comments

@tianocore-issues
Copy link

This issue was created automatically with bugzilla2github

Bugzilla Bug 297

Date: 2016-12-15T01:44:57+00:00
From: peter.kirmeier
To: @BobCF
CC: ye.y.wu

Last updated: 2018-11-05T02:39:48+00:00

@tianocore-issues
Copy link
Author

Comment 1170

Date: 2016-12-15 01:44:57 +0000
From: peter.kirmeier

  • Industry Specification: ---
  • Release Observed: EDK II Master
  • Releases to Fix: EDK II Master
  • Target OS: ---
  • Bugzilla Assignee(s): @BobCF

Using the build_rules.txt to generate makefile commands is not supporting to output the makefile escape sequence "$$". Make uses "$$" to escape the "$" sign, so it will not be parsed as macro/variable. Unfortunately the build tools don't have the possibility to print "$$" into a makefile.

Here an example of such a build_rules.txt modification:
> <Command>
> "$(TOOLS_DIR)\gawk.exe" "NF{gsub(/ *\$$/,&quot;&quot;); print}" infile.in > outfile.out

Here are some more tries to figure out how the $ is processed:

> $() prints $() into the makefile but fails because no macro name is set,
> $($) prints $($) into the makefile but fails because second $ is unknown,
> ${} prints ${} into the makefile but fails because "{" is no valid character,
> $ or $$ or $$$ or $$$$ .. print a single $ into the makefile but fails because next character "/" invalid

Adding the capability of escaping the $ in any way would solve this issue nicely (I prefer).
Preventing cutting down multiple $ signs to a single one should work here, too.

(Related to email "[edk2] $ escape sequence at build_rule.txt": https://lists.01.org/pipermail/edk2-devel/2016-December/005669.html)

@tianocore-issues
Copy link
Author

Comment 1195

Date: 2016-12-21 20:04:05 +0000
From: Chris <<ye.y.wu>>

bug scrub: assign to Yonghong

@tianocore-issues
Copy link
Author

Comment 5491

Date: 2018-11-05 02:39:48 +0000
From: Yonghong Zhu <<yonghong.zhu>>

change to Bob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:basetools priority:high Significant impact. Should be fixed as soon as possible. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant