-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edk2toolext/edk2_logging.py: Log rust errors #665
Conversation
Adds the ability to detect rust build errors and print them at the end of the build when the build fails.
@makubacki is this what you were requesting in #658? We don't currently try to catch the c-style "clippy-like" explanations when compiles fail. See test I know on the mu_basecore side of things you want to catch silent failures in the plugin, but not 100% sure what you are looking for on the extensions side of things as described in #658 |
I was looking to add more context in error messages so problems can better be understood. The output shown in the PR description looks fine to me. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 78.73% 78.75% +0.01%
==========================================
Files 49 49
Lines 4816 4820 +4
==========================================
+ Hits 3792 3796 +4
Misses 1024 1024
|
e7ff927
to
4e16c99
Compare
4e16c99
to
f41fad0
Compare
Adds the ability to detect rust build errors and print them at the end of the build when the build fails.