Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2toolext/edk2_logging.py: Log rust errors #665

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Sep 26, 2023

Adds the ability to detect rust build errors and print them at the end of the build when the build fails.

image

Adds the ability to detect rust build errors and print them at the end
of the build when the build fails.
@Javagedes Javagedes added the enhancement New feature or request label Sep 26, 2023
@Javagedes Javagedes added this to the v0.24.1 milestone Sep 26, 2023
@Javagedes Javagedes self-assigned this Sep 26, 2023
@Javagedes Javagedes requested a review from makubacki September 26, 2023 22:21
@Javagedes Javagedes linked an issue Sep 26, 2023 that may be closed by this pull request
@Javagedes
Copy link
Contributor Author

@makubacki is this what you were requesting in #658? We don't currently try to catch the c-style "clippy-like" explanations when compiles fail. See test test_scan_compiler_output_gcc_mixed_actual.

I know on the mu_basecore side of things you want to catch silent failures in the plugin, but not 100% sure what you are looking for on the extensions side of things as described in #658

@makubacki
Copy link
Member

@makubacki is this what you were requesting in #658? We don't currently try to catch the c-style "clippy-like" explanations when compiles fail. See test test_scan_compiler_output_gcc_mixed_actual.

I know on the mu_basecore side of things you want to catch silent failures in the plugin, but not 100% sure what you are looking for on the extensions side of things as described in #658

I was looking to add more context in error messages so problems can better be understood. The output shown in the PR description looks fine to me.

edk2toolext/edk2_logging.py Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #665 (f41fad0) into master (21f9d65) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   78.73%   78.75%   +0.01%     
==========================================
  Files          49       49              
  Lines        4816     4820       +4     
==========================================
+ Hits         3792     3796       +4     
  Misses       1024     1024              
Files Coverage Δ
edk2toolext/edk2_logging.py 88.46% <100.00%> (+0.25%) ⬆️

@Javagedes Javagedes merged commit f88f276 into tianocore:master Sep 27, 2023
22 of 25 checks passed
@Javagedes Javagedes deleted the add-rust-errors branch September 27, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Better recognize cargo/cargo-make errors
2 participants