Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "edkrepo clean" support for "-ff" option. #173

Open
ndhaller opened this issue Aug 14, 2023 · 0 comments
Open

Add "edkrepo clean" support for "-ff" option. #173

ndhaller opened this issue Aug 14, 2023 · 0 comments
Assignees

Comments

@ndhaller
Copy link
Contributor

Add "edkrepo clean" support for "-ff" option.

"git clean" supports "-f" and "-ff".
https://git-scm.com/docs/git-clean
"Git will refuse to modify untracked nested git repositories (directories with a .git subdirectory) unless a second -f is given."

With edkrepo 3.1.1, "edkrepo clean" does not error when "-ff" is used, but only supports the behavior of "-f".

example edk2 test setup:

Create a Combination that uses enableSubmodule on newer edk2 stable tag.

<Source localRoot="Edk2" remote="Edk2Repo" tag="edk2-stable202305" enableSubmodule="true" />

Manually checkout older Edk2 stable tag.

git checkout edk2-stable202105
git status
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        MdePkg/Library/BaseFdtLib/
        MdePkg/Library/MipiSysTLib/
        UnitTestFrameworkPkg/Library/GoogleTestLib/
        UnitTestFrameworkPkg/Library/SubhookLib/

"edkrepo clean -ffd" runs, but does not remove Untracked files.

"git clean -ffd" runs, and removes Untracked files.

@ashedesimone ashedesimone self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants