From 71a1d579df7abcd4a71515db8df967f12dc5f906 Mon Sep 17 00:00:00 2001 From: Tiago Bento Date: Wed, 20 Nov 2024 18:22:13 -0500 Subject: [PATCH] PR review --- .../src/BpmnEditorClassicPage.tsx | 4 ++-- examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx | 2 +- examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx | 2 +- examples/dmn-editor-on-webapp/src/Sidebar.tsx | 2 +- examples/dmn-editor-standalone-on-webapp/README.md | 8 ++++---- .../README.md | 2 +- .../README.md | 2 ++ .../README.md | 2 +- .../README.md | 2 +- .../README.md | 2 +- .../README.md | 2 ++ 11 files changed, 17 insertions(+), 13 deletions(-) diff --git a/examples/bpmn-editor-classic-on-webapp/src/BpmnEditorClassicPage.tsx b/examples/bpmn-editor-classic-on-webapp/src/BpmnEditorClassicPage.tsx index 140136b4788..0761d683aa3 100644 --- a/examples/bpmn-editor-classic-on-webapp/src/BpmnEditorClassicPage.tsx +++ b/examples/bpmn-editor-classic-on-webapp/src/BpmnEditorClassicPage.tsx @@ -69,8 +69,8 @@ export function BpmnEditorClassicPage() { editorEnvelopeLocator={editorEnvelopeLocator} file={file} setFile={setFile} - fileExtension={"dmn"} - accept={".dmn"} + fileExtension={"bpmn"} + accept={".bpmn"} /> } > diff --git a/examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx b/examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx index d5a088fedd9..f2e78b62318 100644 --- a/examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx +++ b/examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx @@ -20,7 +20,7 @@ import * as React from "react"; import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api"; import { useCallback, useRef, useState } from "react"; -import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav"; +import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav"; import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput"; import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded"; import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel"; diff --git a/examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx b/examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx index d5a088fedd9..f2e78b62318 100644 --- a/examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx +++ b/examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx @@ -20,7 +20,7 @@ import * as React from "react"; import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api"; import { useCallback, useRef, useState } from "react"; -import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav"; +import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav"; import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput"; import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded"; import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel"; diff --git a/examples/dmn-editor-on-webapp/src/Sidebar.tsx b/examples/dmn-editor-on-webapp/src/Sidebar.tsx index d5a088fedd9..f2e78b62318 100644 --- a/examples/dmn-editor-on-webapp/src/Sidebar.tsx +++ b/examples/dmn-editor-on-webapp/src/Sidebar.tsx @@ -20,7 +20,7 @@ import * as React from "react"; import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api"; import { useCallback, useRef, useState } from "react"; -import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav"; +import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav"; import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput"; import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded"; import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel"; diff --git a/examples/dmn-editor-standalone-on-webapp/README.md b/examples/dmn-editor-standalone-on-webapp/README.md index bb27ac93c43..8511b0fbe2e 100644 --- a/examples/dmn-editor-standalone-on-webapp/README.md +++ b/examples/dmn-editor-standalone-on-webapp/README.md @@ -37,11 +37,11 @@ KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/dmn-editor-stand pnpm -F @kie-tools-examples/dmn-editor-standalone-on-webapp start ``` -Open http://localhost:9102 to see the list of files bundled by Webpack, then choose an example: +Open http://localhost:7778 to see the list of files bundled by Webpack, then choose an example: -- State Control: http://localhost:9102/state_control.html -- Read Only: http://localhost:9102/read_only.html -- With Included Models: http://localhost:9102/with_included_models.html +- State Control: http://localhost:7778/state_control.html +- Read Only: http://localhost:7778/read_only.html +- With Included Models: http://localhost:7778/with_included_models.html --- diff --git a/examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/README.md b/examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/README.md index b6c3fd49fdd..7c0b9ea3762 100644 --- a/examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/README.md +++ b/examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/README.md @@ -31,7 +31,7 @@ To make it easier to create `.base64png` files and exporting them to other forma Before running this example, building its dependencies is required. Run the following command on a Terminal: ```shell script -KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev +KIE_TOOLS_BUILD__buildExamples=true pnpm -F kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev ``` ### Building diff --git a/examples/micro-frontends-multiplying-architecture-base64png-editor/README.md b/examples/micro-frontends-multiplying-architecture-base64png-editor/README.md index 4ee227904d6..61208a2deb6 100644 --- a/examples/micro-frontends-multiplying-architecture-base64png-editor/README.md +++ b/examples/micro-frontends-multiplying-architecture-base64png-editor/README.md @@ -21,6 +21,8 @@ This package is a Custom Editor made with React, which enables you to edit a `.b A `.base64png` file is a PNG image converted to base64 without its headers (e.g. data:image/png;base64). +To see it in action, refer to the [Base64 PNG Editor on Webapp](../micro-frontends-multiplying-architecture-base64png-editor-on-webapp/), the [Base64 PNG Editor VS Code Extension](../micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/), or the [Base64 PNG Editor Chrome Extension](../micro-frontends-multiplying-architecture-base64png-editor-chrome-extension/) examples. + --- Apache KIE (incubating) is an effort undergoing incubation at The Apache Software diff --git a/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular/README.md b/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular/README.md index c7832bc3de3..81936b0e708 100644 --- a/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular/README.md +++ b/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular/README.md @@ -19,7 +19,7 @@ The Ping-Pong View is an interface that components can implement to be used inside a Ping-Pong View Envelope. -This package provides a library containing a Ping-Pong View implementation as a Angular application. +This package provides a library containing a Ping-Pong View implementation as a Angular application. To see it in action, refer to the [Ping-Pong Views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/) example. It's build into 3 projects: diff --git a/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react/README.md b/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react/README.md index 3d4987f824b..b7ab7f18730 100644 --- a/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react/README.md +++ b/examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react/README.md @@ -19,7 +19,7 @@ The Ping-Pong View is an interface that components can implement to be used inside a Ping-Pong View Envelope. -Ths package provides a library containing a Ping-Pong View implementation as a React component. +Ths package provides a library containing a Ping-Pong View implementation as a React component. To see it in action, refer to the [Ping-Pong Views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/) example. --- diff --git a/examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/README.md b/examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/README.md index 95ebfb6b0bd..389769bd756 100644 --- a/examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/README.md +++ b/examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/README.md @@ -31,7 +31,7 @@ This package provides a VS Code Extension containing a 'To do' List View, which Before running this example, building its dependencies is required. Run the following command on a Terminal: ```shell script -KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension^... build:dev +KIE_TOOLS_BUILD__buildExamples=true pnpm -F kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension^... build:dev ``` ### Building diff --git a/examples/micro-frontends-multiplying-architecture-todo-list-view/README.md b/examples/micro-frontends-multiplying-architecture-todo-list-view/README.md index cc39fe07ff5..7944241e52d 100644 --- a/examples/micro-frontends-multiplying-architecture-todo-list-view/README.md +++ b/examples/micro-frontends-multiplying-architecture-todo-list-view/README.md @@ -30,6 +30,8 @@ It's divided in the following directories: 1. `vscode` - Provides a convenience class to create a Webview inside a VS Code Extension. +To see it in action, refer to the ['To do' List views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/), or the ['To do' List VS Code Extension](../micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/) examples. + --- Apache KIE (incubating) is an effort undergoing incubation at The Apache Software