You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current merge plugin, when the config item store_tree_hash is enabled, the merge plugin will temporarily save the last commit SHA value while the /merge command triggers. When there is a new commit be submitted, the plugin checks whether the last commit (except the commit of merge-base) SHA changes. If changed, the robot will remove the status/can-merge label on pull request.
In some cases, we want to ensure that some contents in PR other than code will not change during the process from /merge to PR being merged. If changed, PR should be canceled merging.
Do you have any ideas on how to implement it? (Optional)
Add store_verify_payload_hash and verify_payload_template options
In the verify_payload_template option, we can use the syntax of Go Template to define what we need to verify, for example:
When the /merge command trigger, the merge plugin will extract the content according to the verify_payload_template option as payload, then get the SHA value of payload and temporarily store it.
When the PR occurs edited event, if the bot found that the payload SHA has changed, it will remove the status/can-merge label from PR.
The text was updated successfully, but these errors were encountered:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle rotten
Feature Request
Is your feature request related to a Issue or PR(Optional)
Which project: TiKV
PR or Issue Link: new PR requirement and commit message proposal tikv/community#162 (comment)
Describe the feature you'd like:
In the current merge plugin, when the config item
store_tree_hash
is enabled, the merge plugin will temporarily save the last commit SHA value while the/merge
command triggers. When there is a new commit be submitted, the plugin checks whether the last commit (except the commit of merge-base) SHA changes. If changed, the robot will remove thestatus/can-merge
label on pull request.In some cases, we want to ensure that some contents in PR other than code will not change during the process from
/merge
to PR being merged. If changed, PR should be canceled merging.Do you have any ideas on how to implement it? (Optional)
store_verify_payload_hash
andverify_payload_template
optionsverify_payload_template
option, we can use the syntax of Go Template to define what we need to verify, for example:/merge
command trigger, the merge plugin will extract the content according to theverify_payload_template
option as payload, then get the SHA value of payload and temporarily store it.edited
event, if the bot found that the payload SHA has changed, it will remove thestatus/can-merge
label from PR.The text was updated successfully, but these errors were encountered: