Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return type for SoapClientAuth::__doRequest (PHP 8.1.x) #177

Open
ReneGercken opened this issue Sep 12, 2022 · 0 comments
Open

Missing return type for SoapClientAuth::__doRequest (PHP 8.1.x) #177

ReneGercken opened this issue Sep 12, 2022 · 0 comments

Comments

@ReneGercken
Copy link

ReneGercken commented Sep 12, 2022

please add the return type "?string" for the method SoapClientAuth::__doRequest
because it leads to an error like

Deprecated: Return type of Thybag\Auth\SoapClientAuth::__doRequest($request, $location, $action, $version, $one_way = 0)
should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string,
or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ~\vendor\thybag\php-sharepoint-lists-api\src\Thybag\Auth\SoapClientAuth.php on line 84
public function __doRequest($request, $location, $action, $version, $one_way = 0):?string
cweiske added a commit to mogic-le/PHP-SharePoint-Lists-API that referenced this issue Sep 28, 2022
.. "?string" is supported from PHP 7.1 on, so we use that as minimum
required PHP version.

Resolves: thybag#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant