diff --git a/books/computer_systems_app/labs/shell/tsh.c b/books/computer_systems_app/labs/shell/tsh.c index 5f3fb57..a13f315 100644 --- a/books/computer_systems_app/labs/shell/tsh.c +++ b/books/computer_systems_app/labs/shell/tsh.c @@ -206,6 +206,7 @@ void eval(char *cmdline) exit(0); // TODO: dont always exit 0 } else { debug("after fork: parent waiting for child"); + // TODO: should this be set using setpgid(0, 0) in child instead? if (setpgid(pid, pid)) { // give unique proc group ID unix_error("failed to set proc group ID"); }