Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to see the destination of any link before visiting #309

Closed
everdred opened this issue Jul 10, 2023 · 6 comments
Closed

Ability to see the destination of any link before visiting #309

everdred opened this issue Jul 10, 2023 · 6 comments
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@everdred
Copy link

everdred commented Jul 10, 2023

Is your feature request related to a problem? Please describe.
As it is, the only way to view links in a comment is by blindly tapping them, with no way to first see the destination URL. (Unless it's a plain URL link). When following an external link from the main posts feed, it's possible to use the "Share" feature to preview the URL, but it's a convoluted extra step.

Describe the solution you'd like
It would be great if the destination URL could be made visible to the user after tapping a link but before loading the URL. While I can't seem to find a screenshot, the Reddit app RiF had an excellent solution, a pop-up displaying the following:

  1. The full destination URL itself.
  2. A "Go" button to load the link directly in the in-app browser.
  3. A "Share" button to share the link using the native OS sharing system.
  4. A "Copy" button to quickly copy the URL to the system clipboard.

Describe alternatives you've considered
I'm sure there are other ways to implement such a feature, but I believe the functionality described above covers everything one may want to do with a link, short of viewing it directly.

@everdred everdred added the enhancement New feature or request label Jul 10, 2023
@jordan1776
Copy link

jordan1776 commented Jul 10, 2023

Soen apps show links at the bottom of posts as a footnote with preview images for external links and icons for internal links all in the shape of a button.
Screenshot_20230710-113948
Screenshot_20230710-114146

@everdred
Copy link
Author

@jordan1776 That's also an interesting approach, but ideally there would be a way to not show previews until the user chooses to interact with a link. As it is, I have to say I'm not loving the automatic inline display of images within comments.

@jordan1776
Copy link

jordan1776 commented Jul 10, 2023

Also I hadn't noticed that there isn't actually a long press context menu for links at all. That definitely should be in there.

@kovalensky
Copy link

It would great if we could visit lemmy links inside Thunder itself, link are being opened inside built-in webview browser

@micahmo
Copy link
Member

micahmo commented Sep 18, 2023

Related to #709.

@ggichure
Copy link
Collaborator

It would great if we could visit lemmy links inside Thunder itself, link are being opened inside built-in webview browser

This has been done at #832 .
comments, posts, users.

@micahmo micahmo added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Nov 3, 2023
@micahmo micahmo added this to the v0.2.5 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

6 participants