Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube video timestamps don't appear to be working in Thunder's in-app video player. #1619

Open
K4LCIFER opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@K4LCIFER
Copy link
Contributor

K4LCIFER commented Dec 2, 2024

Bug Description

If you add a timestamp to a YouTube link, the video player will start at the beginning of the video rather than at the timestamp.

Examples:
https://sh.itjust.works/post/28710281/15291570
https://sh.itjust.works/post/28613782/15236650

Expected Behaviour

I would expect the video to start at the timestamp.

Steps to Reproduce

  1. Create a link with to a YouTube video with a timestamp in the URL.
  2. Open the link in Thunder
  3. Observe that the video player starts at the beginning of the video rather than at the specified timestamp.

Additional Context

No response

App Version

0.5.1

Device

Pixel 6

OS

Android 15

@K4LCIFER K4LCIFER added the bug Something isn't working label Dec 2, 2024
@ggichure
Copy link
Collaborator

ggichure commented Dec 3, 2024

Thunder uses youtube_player_flutter

should be possible by seeking to position

  _ypfController.seekTo(Duration(seconds: 20));

Edit: for devs

startAt is used rather than seekTo

flags: ypf.YoutubePlayerFlags(
          controlsVisibleAtStart: true,
          autoPlay: autoPlayVideo(),
          enableCaption: false,
          hideControls: false,
          startAt: timestamp ?? 0,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants