From 3a9f8c31bd6e0655b3da36429b6f5195ecf6970e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michalina=20Ciencia=C5=82a?= Date: Wed, 13 Jul 2022 11:30:56 +0200 Subject: [PATCH] Remove Ropsten-related config from deployment job As the Ropsten testnet becomes deprecated in the near future, we are switching to deployment on Goerli. If deployment on Ropsten will be needed in the interm period, we will do it manually, not via GH Actions. --- .github/workflows/contracts.yaml | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/.github/workflows/contracts.yaml b/.github/workflows/contracts.yaml index 3636b439..1cad1d2a 100644 --- a/.github/workflows/contracts.yaml +++ b/.github/workflows/contracts.yaml @@ -99,7 +99,7 @@ jobs: contracts-deployment-testnet: needs: [contracts-build-and-test] - if: github.event_name == 'workflow_dispatch' + if: github.event_name == 'workflow_dispatch' && github.event.inputs.environment == 'goerli' runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -113,15 +113,7 @@ jobs: - name: Install dependencies run: yarn install --frozen-lockfile - # Ultimately, we want to get rid of steps deploying on Ropsten (as it will - # be shut down in Q4 2022) and switch to deployment on Goerli. We're - # leaving both deployment options for the transition period. - - name: Resolve latest contracts on Ropsten - if: github.event.inputs.environment == 'ropsten' - run: yarn upgrade @keep-network/keep-core@1.8.0-ropsten.16 - - - name: Resolve latest contracts on Goerli - if: github.event.inputs.environment == 'goerli' + - name: Resolve latest contracts run: yarn upgrade @keep-network/keep-core@1.8.1-goerli.0 - name: Configure tenderly @@ -129,16 +121,7 @@ jobs: TENDERLY_TOKEN: ${{ secrets.TENDERLY_TOKEN }} run: ./config_tenderly.sh - - name: Deploy contracts on Ropsten - if: github.event.inputs.environment == 'ropsten' - env: - CHAIN_API_URL: ${{ secrets.ROPSTEN_ETH_HOSTNAME_HTTP }} - CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.ROPSTEN_ETH_CONTRACT_OWNER_PRIVATE_KEY }} - KEEP_CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.ROPSTEN_KEEP_ETH_CONTRACT_OWNER_PRIVATE_KEY }} - run: yarn deploy --network ${{ github.event.inputs.environment }} - - - name: Deploy contracts on Goerli - if: github.event.inputs.environment == 'goerli' + - name: Deploy contracts env: CHAIN_API_URL: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }} CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.GOERLI_ETH_CONTRACT_OWNER_PRIVATE_KEY }} @@ -163,6 +146,7 @@ jobs: - name: Notify CI about completion of the workflow # uses: keep-network/ci/actions/notify-workflow-completed@v1 uses: keep-network/ci/actions/notify-workflow-completed@ci-goerli + continue-on-error: true # TODO: remove before merge to main env: GITHUB_TOKEN: ${{ secrets.CI_GITHUB_TOKEN }} with: