Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Climate Integration #7

Open
raychatter opened this issue Feb 1, 2018 · 0 comments
Open

Code Climate Integration #7

raychatter opened this issue Feb 1, 2018 · 0 comments
Labels
enhancement

Comments

@raychatter
Copy link
Contributor

When you try to run the build on TravisCI, the logs show this error:

 WARN -- :       This usage of the Code Climate Test Reporter is now deprecated. Since version
      1.0, we now require you to run `SimpleCov` in your test/spec helper, and then
      run the provided `codeclimate-test-reporter` binary separately to report your
      results to Code Climate.

      More information here:
      https://github.com/codeclimate/ruby-test-reporter/blob/master/README.md

Looks like there are some steps to follow to get Code Climate working again.
@raychatter raychatter mentioned this issue Feb 1, 2018
Merged
@raychatter raychatter assigned kaifius and unassigned kaifius Feb 1, 2018
raychatter added a commit that referenced this issue Feb 1, 2018
@raychatter
Fixes tests on master
e8d866a 
**What**

- Fixes rubocop failures using default rules with the exception of one
  case
- Removes CodeClimate from the code because its implementation was
  deprecated on TravisCI. I opened an issue to look into this:
  #7
- Added the latest stable ruby version (that RVM has to offer) to run on
  TravisCI
- Did the minimum necessary to mock out the repo linter functionality so
  that the existing tests will pass. I will make a follow-up eventually
  to write tests for the repo linter.
- Fixed some small things in the existing tests to get them to pass
- Added test coverage to the `Runner` spec.
raychatter added a commit that referenced this issue Feb 2, 2018
@raychatter
Fixes tests on master
525e5b9 
**What**

- Fixes rubocop failures using default rules with the exception of one
  case
- Removes CodeClimate from the code because its implementation was
  deprecated on TravisCI. I opened an issue to look into this:
  #7
- Added the latest stable ruby version (that RVM has to offer) to run on
  TravisCI
- Did the minimum necessary to mock out the repo linter functionality so
  that the existing tests will pass. I will make a follow-up eventually
  to write tests for the repo linter.
- Fixed some small things in the existing tests to get them to pass
- Added test coverage to the `Runner` spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raychatter @kaifius