This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Fixes #58 - Builder now uses data_root in the default log file path #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious about closing the pull request. This definitely needs to happen, my only question is whether it's worth migrating any existing log files to the new spot. |
|
I closed the request as being new to the code base and only having taken a quick attempt at it, I'm not 100% sure it actually fixes the issue. Once I get a chance to test things a bit more, I'll reopen it. |
|
Cool, fair enough. Thanks for taking a look at the issue, and let us know when you think it's farther along. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58 - Builder now uses data_root (.cruise) in the default log file path.