Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type "model' not supported in class TMLSupportedContent #157

Open
3 tasks done
jden98 opened this issue Jul 18, 2024 · 10 comments
Open
3 tasks done

type "model' not supported in class TMLSupportedContent #157

jden98 opened this issue Jul 18, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@jden98
Copy link

jden98 commented Jul 18, 2024

First Stop

  • I have read and agreed to the ThoughtSpot Dev Tools EULA.
  • I understand that if I have a critical issue with ThoughtSpot, I should reach out to my designated Account Executive and Solutions Consultant team instead of cs_tools.
  • I searched the cs_tools documentation, with the integrated search.

Platform Configuration

cs-tools-info-2024-07-18

Description

When I perform an export from an Org that has 'Models' as well as 'Worksheets', cs_tools scriptability errors stating KeyError: 'model'

Need to upload log files securely?

2024-07-18T21_50_04.log
2024-07-18T21_50_11.log
2024-07-18T21_56_07.log
2024-07-18T22_11_14.log
2024-07-18T22_12_58.log

@jden98 jden98 added the bug Something isn't working label Jul 18, 2024
@boonhapus
Copy link
Collaborator

Hey @jden98 , thanks for reporting this. It is blocked on merging thoughtspot/thoughtspot_tml#22 , which I'll tackle next week

@boonhapus boonhapus added enhancement New feature or request and removed bug Something isn't working labels Jul 20, 2024
@boonhapus boonhapus self-assigned this Jul 20, 2024
@jden98
Copy link
Author

jden98 commented Jul 31, 2024

Hi @boonhapus. I'm wondering if you were able to find any time to look into the PR you mentioned for adding Model support? Is there anything I can do to help move on this?

@boonhapus
Copy link
Collaborator

Hey @jden98 , I did some work on this today and got the PR merged. I need to add a few more tests and docs, then I'll push to pypi, so we can get the latest via CS Tools as well. I'll aim to finish this up tomorrow and will ping you here as well.

@boonhapus
Copy link
Collaborator

boonhapus commented Aug 1, 2024

@jden98 can you try running cs_tools self sync (this will grab the latest thoughtspot_tml , which I just pushed) and then attempt your workflow again?

@jden98
Copy link
Author

jden98 commented Aug 6, 2024

As my workflow is using scriptability, when I call cs_tools tools scriptability export ... I still end up with a KeyError on the word 'model' with the traceback ending in cli\tools\scriptability\app.py:256 in scriptability_export. I'm assuming that even if the tml library is now able to support models, some additional work will be required for this export...?

@boonhapus
Copy link
Collaborator

Thanks @jden98 you're correct. We'll get this type properly supported and pushed to 1.5.10 this week!

@bmofkn
Copy link

bmofkn commented Oct 17, 2024

Hi @boonhapus , we are using v1.5.10 and are getting the same error when using cs_tools tools scriptability export --include-types worksheet --include-system-content ./ --config prod_ts:

KeyError: 'model'

Was this fixed in 1.5.10? Is there a secret patch we can apply :)

csToolsInfo

UPDATE: 2024-10-18 - @boonhapus , FYI, I've tried the following but it still fails when attempting to read the 'model'

cs_tools self update 
cs_tools self sync

curl \
    --silent --show-error --location-trusted \
    https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py \
    | python3 - --install

We only have a single 'model' at the moment but it's preventing us from downloading the TML of all other worksheets. Is there a way to add a flag to skip 'model' for the time being?

@boonhapus
Copy link
Collaborator

Hey @bmofkn @jden98 it looks like this wasn't completely fixed. I pushed a beta update now to skip those kinds of errors, and I'll have to figure out a more complete fix over the weekend.

You can grab it with the --install --beta flag below.

curl \
    --silent --show-error --location-trusted \
    https://raw.githubusercontent.com/thoughtspot/cs_tools/master/cs_tools/updater/_bootstrapper.py \
    | python3 - --install --beta

@bmofkn
Copy link

bmofkn commented Oct 18, 2024

Thanks @boonhapus. That did the trick! Appreciate you taking the time to throw in a workaround. We love cs_tools! Keep up the good work 👍

boonhapus added a commit that referenced this issue Nov 3, 2024
@bmofkn
Copy link

bmofkn commented Nov 4, 2024

@boonhapus, fyi, I just upgraded from 1.5.11b to 1.5.11 and I'm happy to report that my handful of model objects exported successfully. No more errors! Thanks for the previous workaround and the permanent fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants