From 5fd2a38c905b3e9b5f9e1bf52006e634f10f059e Mon Sep 17 00:00:00 2001 From: ShounakB <65479699+Shounaks@users.noreply.github.com> Date: Mon, 9 Dec 2024 01:52:06 +1100 Subject: [PATCH] Fixing Review Comments --- app/mailers/teacher_response_mailer.rb | 2 +- app/models/task.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/mailers/teacher_response_mailer.rb b/app/mailers/teacher_response_mailer.rb index b7f33d0be..a91cf13ce 100644 --- a/app/mailers/teacher_response_mailer.rb +++ b/app/mailers/teacher_response_mailer.rb @@ -5,7 +5,7 @@ def add_general @unsubscribe_url = "#{@doubtfire_host}/#/home?notifications" end - def recieved_notification(project, task) + def received_notification(project, task) return nil if project.nil? add_general diff --git a/app/models/task.rb b/app/models/task.rb index 7015e2ae9..2f95b123c 100644 --- a/app/models/task.rb +++ b/app/models/task.rb @@ -738,9 +738,9 @@ def add_status_comment(current_user, status) # send emails... begin logger.info "Sending comment notification email for project #{project.id}" - TeacherResponseMailer.recieved_notification(project,self).deliver + TeacherResponseMailer.received_notification(project,self).deliver rescue => e - logger.error "Failed to send emails from comment submission. Rescued with error: #{e.message}" + logger.error "Failed to send emails from comment submission.ProjectID: #{project.id} for task: #{self.id} . Rescued with error: #{e.message}" end comment