Add docker build steps #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, it can also be done neatly with the build and push action Example from one of my pipelines: - name: Build and push
uses: docker/build-push-action@v5
with:
context: ${{ matrix.folder }}
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
platforms: linux/amd64,linux/arm64
cache-from: type=gha
cache-to: type=gha
# https://docs.docker.com/build/building/cache/backends/#cache-mode |
|
You are right. I like to possibility to test everything locally with a |
|
@thomseddon would be great to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use modern docker multi platform builds (see https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/) and add step that push the image to the github container registry.
A push to the docker hub is also possible, This would require username and password in the secrets, see https://github.com/docker/login-action?tab=readme-ov-file#docker-hub.
Log of my build https://github.com/StefanSchoof/traefik-forward-auth/actions/runs/9222045539/job/25372382090
image in the github container registry https://github.com/StefanSchoof/traefik-forward-auth/pkgs/container/traefik-forward-auth
fixes #373