Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export coprime_base_insert & subalgebra #1668

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

fingolfin
Copy link
Contributor

@fingolfin fingolfin commented Oct 30, 2024

They don't exist

@fingolfin fingolfin changed the title Don't export removed function coprime_base_insert Don't export coprime_base_insert & subalgebra Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (2b1fd06) to head (5ce2cb3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   75.90%   75.87%   -0.03%     
==========================================
  Files         361      361              
  Lines      113785   113786       +1     
==========================================
- Hits        86363    86340      -23     
- Misses      27422    27446      +24     
Files with missing lines Coverage Δ
src/AlgAss/AbsAlgAss.jl 88.26% <ø> (ø)

... and 35 files with indirect coverage changes

@thofma
Copy link
Owner

thofma commented Oct 31, 2024

downstream tests slowly turning useless

@thofma thofma merged commit 6d4697c into thofma:master Oct 31, 2024
15 of 17 checks passed
@fingolfin fingolfin deleted the mh/coprime_base_insert branch October 31, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants