Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in add_right_scaled_row! #1658

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

fingolfin
Copy link
Contributor

Some issues in add_scaled_row! were fixed in #1591, but not to
add_right_scaled_row!. Rectify this by merging the two functions
into one.

Some issues in `add_scaled_row!` were fixed in thofma#1591, but not to
`add_right_scaled_row!`. Rectify this by merging the two functions
into one.
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (2af99ca) to head (9b94f3e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Sparse/Row.jl 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   75.85%   75.95%   +0.09%     
==========================================
  Files         361      361              
  Lines      113719   113694      -25     
==========================================
+ Hits        86262    86356      +94     
+ Misses      27457    27338     -119     
Files with missing lines Coverage Δ
src/Sparse/Row.jl 79.48% <62.50%> (+5.57%) ⬆️

... and 22 files with indirect coverage changes

@thofma thofma merged commit 66ab098 into thofma:master Oct 25, 2024
17 checks passed
@fingolfin fingolfin deleted the mh/fix-add_right_scaled_row branch October 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants