Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component specific logic to builtin components #26

Open
martinpengellyphillips opened this issue Sep 30, 2022 · 0 comments
Open

Move component specific logic to builtin components #26

martinpengellyphillips opened this issue Sep 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@martinpengellyphillips
Copy link
Contributor

martinpengellyphillips commented Sep 30, 2022

Currently the core has some logic to control visibility of the input, but this only makes sense for the specific component implementation. A custom component setup might not want this (e.g #23) so move it out of the core and into the builtin Input component instead.

Relevant code: element.style.setProperty("opacity", inputIsHidden() ? "0" : "1");

Similarly, it might be better to have the control of the input value moved to the component level rather than core: createRenderEffect(() => (element.value = inputValue()));

Alternatively, move to returning props to set in the custom components for all the component specific logic, rather than automatically adding in the core.

@martinpengellyphillips martinpengellyphillips changed the title Move style specific logic to builtin components Move component specific logic to builtin components Sep 30, 2022
@martinpengellyphillips martinpengellyphillips added the enhancement New feature or request label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant