You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the core has some logic to control visibility of the input, but this only makes sense for the specific component implementation. A custom component setup might not want this (e.g #23) so move it out of the core and into the builtin Input component instead.
Similarly, it might be better to have the control of the input value moved to the component level rather than core: createRenderEffect(() => (element.value = inputValue()));
Alternatively, move to returning props to set in the custom components for all the component specific logic, rather than automatically adding in the core.
The text was updated successfully, but these errors were encountered:
martinpengellyphillips
changed the title
Move style specific logic to builtin components
Move component specific logic to builtin components
Sep 30, 2022
Currently the core has some logic to control visibility of the
input
, but this only makes sense for the specific component implementation. A custom component setup might not want this (e.g #23) so move it out of the core and into the builtin Input component instead.Relevant code:
element.style.setProperty("opacity", inputIsHidden() ? "0" : "1");
Similarly, it might be better to have the control of the input value moved to the component level rather than core:
createRenderEffect(() => (element.value = inputValue()));
Alternatively, move to returning props to set in the custom components for all the component specific logic, rather than automatically adding in the core.
The text was updated successfully, but these errors were encountered: