Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop requiring "sign/" prefix for signing events #99

Open
jku opened this issue Oct 9, 2023 · 0 comments
Open

stop requiring "sign/" prefix for signing events #99

jku opened this issue Oct 9, 2023 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Oct 9, 2023

I originally required "sign/" prefix anticipating slightly more PRs that modify the git repository (but are not actually signing events). That does not seem to happen much as there should be almost nothing else in the repository, and the few that happen we can filter.
So:

  • I think we can consider every branch a signing event if there are changes in either targets/ or metadata/ (and branch is not "main" or "publish")
  • False positives should be easy for maintainers to handle -- just close the issue or don't create branches like that on the main repository
@jku jku added enhancement New feature or request discussion labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant