Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make username comparison case insensitive #419

Open
jku opened this issue Aug 28, 2024 · 1 comment
Open

make username comparison case insensitive #419

jku opened this issue Aug 28, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented Aug 28, 2024

@SantiagoTorres in signer configuration and @santiagotorres in metadata should be considered the same user

@jku
Copy link
Member Author

jku commented Aug 28, 2024

There's multiple places where we do this comparison. Two ways to go about it:

  • switch all comparisons to not do if s == user.name and instead create a User.matches(s) that does the right thing -- the issue here is that future code must also remember to use this method...
  • alternatively make sure user-name is deserialized to lowercase when the config file .tuf-on-ci-sign.ini is read, and that tuf-on-ci-delegate input that asks for new signer names converts to lowercase before storing the signer name. This should ensure we always only process lowercase -- minor downside is that signer names printed on CLI will then always be lowercase

I think the second option is easier to implement so I will go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant