Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated solid-start peer dep causes peer deps issues with npm #306

Closed
florian-lefebvre opened this issue Jun 9, 2024 · 1 comment
Closed

Outdated solid-start peer dep causes peer deps issues with npm #306

florian-lefebvre opened this issue Jun 9, 2024 · 1 comment

Comments

@florian-lefebvre
Copy link

Hi there! In @astrojs/[email protected] I added support for solid-devtools, and added it as an optional peer dependency of the package.

However, it turns out that solid-devtools has a dependency on an older version of solid-start, which causes peer dependencies error when installing with npm (see withastro/astro#11217). Do you think it could be possible to update it?

Thanks and let me know if/how I can help!
epompeii added a commit to bencherdev/bencher that referenced this issue Oct 29, 2024
@epompeii
bump_astro
d5aac0e 
- withastro/astro#11217
- thetarnav/solid-devtools#306
epompeii added a commit to bencherdev/bencher that referenced this issue Oct 29, 2024
@epompeii
astro_solid_bump
b2cfef0 
- withastro/astro#11217
- thetarnav/solid-devtools#306
@thetarnav
Copy link
Owner

solid-start dependency is removed now in #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thetarnav @florian-lefebvre