Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name option to createContext #132

Open
thetarnav opened this issue Oct 3, 2022 · 0 comments
Open

Add name option to createContext #132

thetarnav opened this issue Oct 3, 2022 · 0 comments
Labels
enhancement New feature or request solid Changes to solid are required

Comments

@thetarnav
Copy link
Owner

thetarnav commented Oct 3, 2022

Context nodes should be able to be named, just as signals and computations.
Without names, context nodes don't have anything besides their value (which takes a second to inspect and identify) to identify different context nodes by.

Such change would need to be added to solid first—createContext doesn't have an option for that.
(PR adding that to solid: solidjs/solid#1266)

Then the debugger would have to be modified to send the name field to the extension.
Since the computations in solid have their name generated if one isn't passed using options, the generated names would have to also be displayed to the user. At least until that behavior is changed.

@thetarnav thetarnav added enhancement New feature or request solid Changes to solid are required labels Oct 3, 2022
@thetarnav thetarnav changed the title Add name option to createComtext Add name option to createContext Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request solid Changes to solid are required
Projects
None yet
Development

No branches or pull requests

1 participant