Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw with Bitcoin signature #353

Closed
1 of 3 tasks
Tracked by #319
nkuba opened this issue Apr 15, 2024 · 0 comments · Fixed by #474
Closed
1 of 3 tasks
Tracked by #319

Withdraw with Bitcoin signature #353

nkuba opened this issue Apr 15, 2024 · 0 comments · Fixed by #474
Assignees
@r-czajkowski
Labels
🎨 dApp dApp 🔌 SDK TypeScript SDK Library

Comments

@nkuba
Copy link
Member

nkuba commented Apr 15, 2024 •
edited
Loading

A Bitcoin user who is the owner of stBTC tokens held by OrangeKit Safe should be able to request a withdrawal with a Bitcoin message signature over a transaction submitted to the Safe.
@nkuba nkuba mentioned this issue Apr 15, 2024
Closed
@nkuba nkuba added 🔌 SDK TypeScript SDK Library 🎨 dApp dApp labels Apr 15, 2024
@nkuba nkuba mentioned this issue Jun 10, 2024
Closed
@nkuba nkuba mentioned this issue Jun 20, 2024
Merged
kkosiorowska added a commit that referenced this issue Jun 28, 2024
@kkosiorowska
Withdrawals (#474)
8ae1ec6 
Depends on: #472 
Closes: #353

This PR adds support for withdrawals in SDK and Acre dapp. To request a
redemption we need to implement our custom redeemer proxy. Our redeemer
proxy builds the redemption data and sends the redemption request
transaction via Orangekit SDK.

Here we also hardcode the `ethers` version to `6.10.0` (without `^`) in
the `solidity` and `sdk` workspaces. The version of `ethers` in the
`solidity` workspace has been resolved to `6.13.1` and the `sdk`
workspace depends on it, so pnpm resolves `ethers` in `sdk` to `6.13.1`
under the hood where there are some changes in the API and causes tests
and builds to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-czajkowski r-czajkowski

Labels
🎨 dApp dApp 🔌 SDK TypeScript SDK Library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Withdrawals thesis/acre
2 participants
@nkuba @r-czajkowski