From e201cf56d9aad9f03db728387056b32477f21037 Mon Sep 17 00:00:00 2001 From: Del Date: Sun, 28 May 2017 13:38:29 +0700 Subject: [PATCH 1/4] Fix broken test case --- .travis.yml | 1 - tests/Message/ListPlansTest.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 67753ce6..3ded76a8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,6 @@ php: - 5.4 - 5.5 - 5.6 - - hhvm before_script: - composer install -n --dev --prefer-source diff --git a/tests/Message/ListPlansTest.php b/tests/Message/ListPlansTest.php index 8afdfe80..abb1d943 100644 --- a/tests/Message/ListPlansTest.php +++ b/tests/Message/ListPlansTest.php @@ -4,7 +4,7 @@ use Omnipay\Tests\TestCase; -class ListInvoicesRequestTest extends TestCase +class ListPlansTest extends TestCase { public function setUp() { @@ -33,6 +33,6 @@ public function testSendSuccess() */ public function testSendFailure() { - this->assertTrue(true); + $this->assertTrue(true); } } From fa28efb02352081fc406a9cc1d8e780e61ddcba6 Mon Sep 17 00:00:00 2001 From: Del Date: Sun, 28 May 2017 13:44:26 +0700 Subject: [PATCH 2/4] Fix mock file name --- tests/Message/ListPlansTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Message/ListPlansTest.php b/tests/Message/ListPlansTest.php index abb1d943..98d4823e 100644 --- a/tests/Message/ListPlansTest.php +++ b/tests/Message/ListPlansTest.php @@ -18,7 +18,7 @@ public function testEndpoint() public function testSendSuccess() { - $this->setMockHttpResponse('ListPlans.txt'); + $this->setMockHttpResponse('ListPlansSuccess.txt'); $response = $this->request->send(); $this->assertTrue($response->isSuccessful()); From 5ae35858856c44775eada7ec308149c609885dcd Mon Sep 17 00:00:00 2001 From: Del Date: Sun, 28 May 2017 13:49:27 +0700 Subject: [PATCH 3/4] Fix JSON syntax --- tests/Mock/ListPlansSuccess.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Mock/ListPlansSuccess.txt b/tests/Mock/ListPlansSuccess.txt index bb15919b..e02bb461 100644 --- a/tests/Mock/ListPlansSuccess.txt +++ b/tests/Mock/ListPlansSuccess.txt @@ -8,10 +8,10 @@ Access-Control-Allow-Credentials: true Cache-Control: no-cache, no-store { - "object" => "list", - "url" => "/v1/plans", - "has_more" => false, - "data" => [ + "object": "list", + "url": "/v1/plans", + "has_more": false, + "data": [ { "id": "test-1", "object": "plan", From 543c2c7b54b6cde8903cad0964547bae19ed36d5 Mon Sep 17 00:00:00 2001 From: Del Date: Sun, 28 May 2017 13:52:06 +0700 Subject: [PATCH 4/4] Tidy up test case --- tests/Message/ListPlansTest.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Message/ListPlansTest.php b/tests/Message/ListPlansTest.php index 98d4823e..54e4641f 100644 --- a/tests/Message/ListPlansTest.php +++ b/tests/Message/ListPlansTest.php @@ -6,6 +6,9 @@ class ListPlansTest extends TestCase { + /** @var ListPlansRequest */ + protected $request; + public function setUp() { $this->request = new ListPlansRequest($this->getHttpClient(), $this->getHttpRequest());