Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Line Items #107

Open
Sarke opened this issue Mar 15, 2018 · 2 comments
Open

Add Line Items #107

Sarke opened this issue Mar 15, 2018 · 2 comments

Comments

@Sarke
Copy link

Sarke commented Mar 15, 2018

Is there a way to use any of the additional request properties, such as order line items and shipping address? Those defined here: https://developer.authorize.net/api/reference/#payment-transactions

If not, is this going to be added? Without it, it is very limited functionality.

It would be a good idea to have a method to add generic properties into the request, so we are not limited to what is specifically defined in AIMAbstractRequest.

EDIT: Nevermind! I see there are CreditCard and ItemBag from the main OmniPay package that deal with this.

@Sarke Sarke changed the title Add Line Items, Shipping address, etc Add Line Items Mar 15, 2018
@Sarke
Copy link
Author

Sarke commented Mar 15, 2018

It appears that only the CreditCard class is used, the ItemBag is not.

As suggested, making a public method for adding request data would allow us to use payment gateway features without it being implemented in OmniPay.

@judgej
Copy link
Member

judgej commented Mar 15, 2018

Yes you are right, the lineItems/ItemBag seems to have been totally overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants