Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to docs that you can't use your own Faker instance #467

Closed
igorsantos07 opened this issue Jun 22, 2020 · 3 comments
Closed

Add warning to docs that you can't use your own Faker instance #467

igorsantos07 opened this issue Jun 22, 2020 · 3 comments

Comments

@igorsantos07
Copy link

igorsantos07 commented Jun 22, 2020

My tests already had a custom Faker installation, but it's not obvious from the docs you must use the facade, otherwise, you'll get duplicated entries.

And no need to suggest "we accept PRs", I'm posting this as an up for grabs. I may come back if I get some free time, as this lib seems useful and is definitely needing some love, but I definitely can't guarantee.

Speaking of PRs btw, #426 is definitely lacking.

@GrahamCampbell
Copy link
Member

but it's not obvious from the docs you must use the facade, otherwise, you'll get duplicated entries.

That's not true. You just need to persist your instance between tests...

@igorsantos07
Copy link
Author

igorsantos07 commented Jun 24, 2020 via email

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jun 24, 2020

It is not a bug in codeception. It's a bug in your test. If you make a new instance each time, of course it doesn't know about what has been generated in the past...

@thephpleague thephpleague locked as off-topic and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants