-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning to docs that you can't use your own Faker instance #467
Comments
That's not true. You just need to persist your instance between tests... |
So this is, at the very least, a Codeception bug. I'll check what they do
with your library, then, as I guess you're not interested in debugging.
Nonetheless, if someone noticed that, why not mentioning this in docs
instead of straight out closing the issue?
Not sure if I'm the doc freak or you're the careless undocumenter.
…On Mon, Jun 22, 2020, 06:23 Graham Campbell ***@***.***> wrote:
but it's not obvious from the docs you must use the facade, otherwise,
you'll get duplicated entries.
That's not true. You just need to persist your instance between tests...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEB6S5SQQ6ZKNZ5U7W3YC3RX4PHPANCNFSM4OEGL4FQ>
.
|
It is not a bug in codeception. It's a bug in your test. If you make a new instance each time, of course it doesn't know about what has been generated in the past... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
My tests already had a custom Faker installation, but it's not obvious from the docs you must use the facade, otherwise, you'll get duplicated entries.
Speaking of PRs btw, #426 is definitely lacking.
The text was updated successfully, but these errors were encountered: