Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow write to private properties and/or create instance without constructor calling #459

Open
JanMikes opened this issue Dec 4, 2018 · 1 comment

Comments

@JanMikes
Copy link

JanMikes commented Dec 4, 2018

Hello, i have private constructor for my entities, which was a problem. As well i have NO setters (i am huge fan of DDD).

I was able to create instances of entities without calling constructor and setting private properties without any setters like this:

/** @var FactoryMuffin $fm */
$fm->define(User::class)->setMaker(function() {
	$user = (new \ReflectionClass(User::class))->newInstanceWithoutConstructor();

	$property = new \ReflectionProperty(User::class, 'emailAddress');
	$property->setAccessible(true);
	$property->setValue($user, EmailAddress::fromString('[email protected]'));

	$property = new \ReflectionProperty(User::class, 'passwordHash');
	$property->setAccessible(true);
	$property->setValue($user, ClearTextPassword::fromString('123')->makeHash());

	return $user;
});

I believe that the FactoryMuffin::generate() method could be rewritten like this (added as another possible fallback), rewrite this:

if (method_exists($model, $setter) && is_callable([$model, $setter])) {
                $model->$setter($value);
            } else {
                $model->$key = $value;
            }

To set value via property reflection.

@JanMikes
Copy link
Author

JanMikes commented Dec 4, 2018

Possibly related to #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant