-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroller is not scrolling to the bottom when content has images #72
Comments
Hey, can I get a fiddle please (you may use this one as a base)? |
Hi, you can try this here But try clear your browser history everytime u test it. Just to make sure you download the complete images from the links instead of using cache image. |
I actually found someone is adding the extra image loaded event from your version. But the version does not included some features that you've added recently. |
I've been thinking of moving away from MutationObservers and using a ResizeObserver for Version 2. That would probably fix this. It would however require users to use the directive differently (see: https://rawgit.com/WICG/ResizeObserver/master/examples/chat.html). We'll see. |
We'll probably move to ResizeObservers. This will cause a breaking change as now the html will look like this (taken from WICG chat example): <div class="chat"> <!-- chat has the scrollbar -->
<div class="chat-text"> <!-- chat-text contains chat text -->
<div>jack: hi </div>
<div>jill: hi </div>
</div>
</div We might have to use: https://www.npmjs.com/package/resize-observer-polyfill |
I'll be moving to |
Thanks @theomessin , can't wait to try on version 2 :) |
HI @theomessin can i know when will you implement the version 2? |
HI @weeliem not sure at the moment. Pretty busy with other stuff |
I am very busy till the end of the month. Will try to pick this up in June |
Describe the bug
Scroller is not scrolling to the bottom when content has images.
To Reproduce
Steps to reproduce the behavior:
Add images(medium / large sizes) into vue-chat-scroll
Expected behavior
Completely scroll to bottom
Screenshots
https://prnt.sc/s07c7s
Additional context
This is probably due to vue-chat-scroll initialised before the images are completely loaded
The text was updated successfully, but these errors were encountered: